[coreboot] [PATCH] fix normal vs. fallback
mylesgw at gmail.com
Thu Jul 8 20:11:43 CEST 2010
On Thu, Jul 8, 2010 at 12:09 PM, Myles Watson <mylesgw at gmail.com> wrote:
> On Thu, Jul 8, 2010 at 11:56 AM, Patrick Georgi <patrick at georgi-clan.de> wrote:
>> Am 08.07.2010 19:50, schrieb Myles Watson:
>>> BOOTBLOCK_NORMAL allows the user to use CMOS values to select which
>>> image to boot. This patch:
>>> - makes BOOTBLOCK_NORMAL depend on USE_OPTION_TABLE
>> This would prevent the "old" scheme of building a fallback image (which
>> is built first) with BOOTBLOCK_NORMAL and _no_ USE_OPTION_TABLE (so it
>> uses the hardcoded defaults) and a normal image with USE_OPTION_TABLE.
> So I probably went too far. I should have made it depend on HAVE_OPTION_TABLE.
I admit I've never used it. I just tried to build it to see if there
were any warnings, and it wouldn't build. Maybe it would be better if
you fixed it the right way.
More information about the coreboot