[coreboot] [PATCH]Jetway PA78VM5
marcj303 at gmail.com
Mon Jul 19 23:19:25 CEST 2010
On Thu, Jul 15, 2010 at 2:01 AM, Qing Pei Wang <wangqingpei at gmail.com> wrote:
> hi all,
> in order to make the code much clear, i update the patch which sent
> yesterday to make all messages fit for "PA78VM5".
> Signed-off-by Wang Qing Pei <wangqingpei at gmail.com>
Can you break up this patch into smaller parts, fintek sio and
mainboard? That would make it easier to review.
Also, Can you give a summary of what the code supports. What works and
what doesn't. What about internal graphics, pci e slots etc?
Here are a few items to look at:
Do you need the mb_sysconf.h file? I don't think that the 8132 and
8111 stuff is needed on your platform.
In devicetree.cb, You don't need multiple 18.0 devices.
+//used by incoherent_ht
+#define FAM10_SCAN_PCI_BUS 0
+#define FAM10_ALLOCATE_IO_RANGE 0
Are these used? I think that they may be outdated. Maybe make a patch
for all fam10 platforms?
Remove these old includes that are commented out.
Remove spd_addr.h file since it isn't used.
+// int fixup_scsi;
+// int fixup_vga;
Remove these old lines. I don't think that they are used for anything
More information about the coreboot