[coreboot] Broken include paths

Myles Watson mylesgw at gmail.com
Mon Jul 26 19:28:27 CEST 2010

On Mon, Jul 26, 2010 at 11:09 AM, Peter Stuge <peter at stuge.se> wrote:
> Myles Watson wrote:
>> There are many ways to fix it, but I'm not sure which one is the
>> correct (most future-proof) way.
> ..
>> 3. Just use the path
> I think this is *by far* the cleanest approach!

I agree that it looks the best.  I'm worried that it introduces ambiguity.

#include <path/file.h>

Could look in src/path/file.h or src/include/path/file.h and others

Is that what we want?  Should we remove -I$(src) from the command line
in the long term?

from src/arch/i386/Makefile.bootblock.inc:	

$(CC) -MMD -x assembler-with-cpp -DASSEMBLY -E -I$(src)/include
-I$(src)/arch/i386/include -I$(obj) -I$(obj)/bootblock -include
$(obj)/config.h -I. -I$(src) $< -o $@

It seems like it could be simpler.  I also don't understand the order.


More information about the coreboot mailing list