[coreboot] Broken include paths

Myles Watson mylesgw at gmail.com
Mon Jul 26 21:28:09 CEST 2010

On Mon, Jul 26, 2010 at 1:22 PM, Peter Stuge <peter at stuge.se> wrote:
> Patrick Georgi wrote:
>> > .h files outside include/
>> > They should probably be moved to include/
>> Mainboards need to include chipset specific information, and I'd
>> like to avoid moving all that into include/ if possible.
> Why not do it?
It's used in multiple places, but only two or three usually.

> Myles Watson wrote:
>> I think that's a reasonable exception to the rule.
> Why have an exception at all?
So src/include/ doesn't get cluttered.

>> Some of that code could move to the chipsets, but not all of it.
> Hmm, can you clarify?
I was thinking of some of the ACPI code, that is not
mainboard-dependent but chipset-dependent.  That's been slowly moving
to the chipset directories.

Some of the mainboard initialization code calls functions depending on
what's on the board.  That won't be moved.


More information about the coreboot mailing list