[coreboot] Update on NOKIA-IP530

mbertens mbertens at xs4all.nl
Fri Jun 4 20:38:03 CEST 2010

On Fri, 2010-06-04 at 12:29 -0600, Myles Watson wrote:
> > Signed-off-by: Marc Bertens <mbertens at xs4all.nl>
> Acked-by: is the tag you want if you agree with the patch and want it to be
> committed.  I'm hoping that means you tested it.
Ok, i mis understand you then, because i was not seeing any real
changes. But i will test the patches. 
> > > >  - I understood most of the changes, but why remove the register
> > > > settings for the keyboard and mouse?
> Were they causing a problem?
The IP530 doesn't have a mouse or keyboard, they where not a problem,
but i dont like any thing these that is not nessary.
> > > >  - there's no reason we can' t use tabs when it gets committed, I just
> > > > couldn't see the differences.
> Did you have a preference here?
Regarding the tabs, i was just folling the coding rules, nothing more or
less :-)
> Thanks,
> Myles

I will send you an ack when i tested it.


More information about the coreboot mailing list