[coreboot] [PATCH] Fix geode lx VSA loading

Peter Stuge peter at stuge.se
Sat Jun 5 22:48:36 CEST 2010


Edwin Beasant wrote:
> This patch fixes the option rom code that was buggy

Content-Description: coreboot-v4-vsa-fix.patch
> @@ -141,21 +146,25 @@
>  	mov	%ax, %ds
>  	lidt	__realmode_idt
>  
> +	/* initialize registers for option rom lcall */
> +	movl	__registers +  0, %eax
..
>  	/* Set all segments to 0x0000, ds to 0x0040 */
> +
>  	mov	%ax, %es
>  	mov	%ax, %fs
>  	mov	%ax, %gs
>  	mov	$0x40, %ax
>  	mov	%ax, %ds
> +	popal
>  
> -	/* initialize registers for option rom lcall */
> -	movl	__registers +  0, %eax

Thanks for finding that one Edwin! Good find. I read through it a few
times but didn't catch the ds change/memory ref.


//Peter




More information about the coreboot mailing list