[coreboot] [commit] r5609 - in trunk/src: drivers drivers/dec drivers/dec/21143 drivers/ti drivers/ti/pcmcia-cardbus include/device mainboard/nokia/ip530
Myles Watson
mylesgw at gmail.com
Mon Jun 7 20:20:33 CEST 2010
On Sat, Jun 5, 2010 at 3:11 PM, Peter Stuge <peter at stuge.se> wrote:
> I have several issues with this commit. I pointed out at least one of
> them already very long ago!
The attached patch addresses some of the issues.
It mostly moves drivers to southbridge/ti/ and southbridge/dec/
Signed-off-by: Myles Watson <mylesgw at gmail.com>
>> +++ trunk/src/include/device/pci_ids.h Fri Jun 4 21:53:55 2010 (r5609)
>> @@ -696,6 +696,7 @@
>> #define PCI_DEVICE_ID_TI_4410 0xac41
>> #define PCI_DEVICE_ID_TI_4451 0xac42
>> #define PCI_DEVICE_ID_TI_1420 0xac51
>> +#define PCI_DEVICE_ID_TI_1520 0xAC55
>
> Somewhat minor, but please use lower case for a-f to look like other
> values in the file.
Unfortunately, this is not consistent in that file, but I changed it
so at least it's consistent within TI values.
>
>> @@ -1741,6 +1742,10 @@
>> #define PCI_DEVICE_ID_CCD_B00C 0xb00c
>> #define PCI_DEVICE_ID_CCD_B100 0xb100
>>
>> +#define PCI_VENDOR_ID_NOKIA 0x13B8 // Nokia Telecommunications oy
>> +#define PCI_VENDOR_ID_NOKIA_WIRELESS 0x1603 // Nokia Wireless Communications
>> +#define PCI_VENDOR_ID_NOKIA_HOME 0x1622 // Nokia Home Communications
Removed.
Thanks,
Myles
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nokia.diff
Type: text/x-patch
Size: 19343 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100607/80edcfa0/attachment.diff>
More information about the coreboot
mailing list