[coreboot] [PATCH] Simplify device enabling and initialization

Myles Watson mylesgw at gmail.com
Thu Jun 17 18:19:03 CEST 2010

On Thu, Jun 17, 2010 at 2:04 AM, Peter Stuge <peter at stuge.se> wrote:
> Myles Watson wrote:
>> If we initialize and enable devices in the order that they are found
>> in the tree, instead of the order that they were added to the list, it
>> simplifies the code.  It also makes it so that removing a device from
>> the devicetree.cb file won't change when its resources are enabled.
> ..
>> Signed-off-by: Myles Watson <mylesgw at gmail.com>
> Acked-by: Peter Stuge <peter at stuge.se>
Rev 5633.

I copied the s2881 code into a driver stub, since Ward said he's
willing to test.

>> This patch breaks the s2881, which was doing some odd acrobatics in
>> order to get a device initialized after its parent.
> If neccessary then I would be in favor of mainboard-specific hooks
> from coreboot, that are separate from the device tree. But maybe the
> init for s2881 can be done using a coreboot "driver" ?
That could work.  I think it might get abused, though.


More information about the coreboot mailing list