[coreboot] [PATCH] Simplify device enabling and initialization
ward at gnu.org
Tue Jun 22 22:24:44 CEST 2010
On Tue, Jun 22, 2010 at 01:30:45PM -0600, Myles Watson wrote:
> > > The ADM1027 doesn't expect to have children, so it has no scan_bus
> > > method. I had thought that the ADM1027 was some kind of a controller
> > > for the ADT4763, but it looks like the same type of device. Is there
> > > really an ADM1027 on your board? I don't see it in your sensors
> > > output.
> > >
> > > So... the first two patches are the same as before. The third patch
> > > adds a scan_bus method to the ADM1027 so that the ADT4763 can be
> > > initialized, and the fourth patch replaces the ADM1027 with the
> > > ADT4763 in the device tree, and removes the third patch.
> > >
> > > I'd be interested in head + 1 + 2 + 3, and head + 1 + 2 + 3 + 4.
> > See
> > http://ward.vandewege.net/coreboot/s2881/20100621-myles/
> Thanks for testing Ward! As far as I can see, both worked, but 1+2+3+4 is
> cleaner. It doesn't look like there is an ADM1027 on your board.
> Is there something missing before an Ack & commit?
I think it's good. Thanks for writing the patches!
Acked-by: Ward Vandewege <ward at gnu.org>
Ward Vandewege <ward at gnu.org>
More information about the coreboot