[coreboot] [PATCH] Convert Geode GX2 boards to CAR

[Myles Watson]

On Tue, Jun 29, 2010 at 2:23 PM, Nils <njacobs8 at hetnet.nl> wrote:
> Hi All,
>
> Nils wrote:
>>Peter wrote:
>>>Nils wrote:
>>>> +++ src/cpu/amd/model_gx2/cache_as_ram.inc    (revision 0)
>>>..
>>>> +     post_code(0xc5)
>>>> +DCacheSetupBad:
>>>> +     hlt             /* issues */
>>>> +     jmp DCacheSetupBad
>>>
>>>Should this maybe fail more loudly than a POST code, which can be
>>>disbled completely. Would be nice to say something on serial.
>>
>>I would like that but that`s how it is in Geode LX.
>>I try if can do a follow up patch for that after this is in. OK?
>
> I spent  some time trying to get a debug message printed here but i am
> probably to stupid.
> I tried with printk and print_debug but the assembler complained.
> Could someone perhaps point me to an example in another assembler file?
> I could not find one.

In general we don't do printk in assembly.  You shouldn't do any
before console_init, and this is probably earlier than that.  I think
Cache-as-RAM setup is too early to debug with serial.

Thanks,
Myles