[coreboot] [PATCH] YABEL compilation warnings
mylesgw at gmail.com
Fri Mar 5 19:28:15 CET 2010
On Fri, Mar 5, 2010 at 10:28 AM, Stefan Reinauer <stepan at coresystems.de>wrote:
> On 3/5/10 4:13 PM, Myles Watson wrote:
> I think we should get rid of that warning, since we conditionally call
>> functions based on debugging and various config variables.
> I think we should instead just drop CONFIG_WARNINGS_ARE_ERRORS for Qemu
> rather than dropping warnings.
I think that setting for Qemu has reduced the number of warnings in our code
by a lot. It's easier for the original developer to deal with warnings when
the code is written.
> Or maybe only add -Wno-unused-function if
CONFIG_WARNINGS_ARE_ERRORS is active, at least. Or maybe add an Option
> "Warnings good for Developers"?
I can see your point. I'd rather not have to special case warnings either.
What would you suggest for the two emulator functions in yabel that are
unused right now? Should we comment them out until they are used?
> Is there a case where it helps enough to justify all the warnings?
> Yes, they indicate that there is dead code. This is, not only but
> especially useful to recognize if / how code should / could be restructured.
I worry that having too many warnings makes it so that "important" ones
(ones that cause bugs) get missed.
> Signed-off-by: Myles Watson <mylesgw at gmail.com>
> With the -Wno-unused-functions taken care of:
I wasn't sure how you wanted it taken care of. I left it for another patch.
> Acked-by: Stefan Reinauer <stepan at coresystems.de> <stepan at coresystems.de>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the coreboot