[coreboot] [commit] r5209 - trunk/src

repository service svn at coreboot.org
Sun Mar 14 22:31:07 CET 2010


Author: oxygene
Date: Sun Mar 14 22:31:05 2010
New Revision: 5209
URL: http://tracker.coreboot.org/trac/coreboot/changeset/5209

Log:
Move deprecated Kconfig options to their own file,
so it's clear that they should be gone.
More can (and should) be added, but this is a start.

Of course, eliminating the uses of the flags (and then
the flags themselves) that are in Kconfig.deprecated_options
is a noble task for the future :-)

Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
Acked-by: Stefan Reinauer <stepan at coresystems.de>

Added:
   trunk/src/Kconfig.deprecated_options
Modified:
   trunk/src/Kconfig

Modified: trunk/src/Kconfig
==============================================================================
--- trunk/src/Kconfig	Sun Mar 14 22:25:03 2010	(r5208)
+++ trunk/src/Kconfig	Sun Mar 14 22:31:05 2010	(r5209)
@@ -283,28 +283,6 @@
 	  This variable specifies whether a given board has a hard_reset
 	  function, no matter if it's provided by board code or chipset code.
 
-config BOARD_HAS_HARD_RESET
-	bool
-	default n
-	help
-	  This variable specifies whether a given board has a reset.c
-	  file containing a hard_reset() function.
-
-config BOARD_HAS_FADT
-	bool
-	default n
-	help
-	  This variable specifies whether a given board has a board-local
-	  FADT in fadt.c. Long-term, those should be moved to appropriate
-	  chipset components (eg. southbridge)
-
-config HAVE_BUS_CONFIG
-	bool
-	default n
-	help
-	  This variable specifies whether a given board has a get_bus_conf.c
-	  file containing bus configuration data.
-
 config HAVE_INIT_TIMER
 	bool
 	default n if UDELAY_IO
@@ -841,3 +819,5 @@
 config ID_SECTION_OFFSET
 	hex
 	default 0x10
+
+source src/Kconfig.deprecated_options

Added: trunk/src/Kconfig.deprecated_options
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ trunk/src/Kconfig.deprecated_options	Sun Mar 14 22:31:05 2010	(r5209)
@@ -0,0 +1,33 @@
+# Options in this file are meant to be deprecated. Avoid their use
+# if possible, and if you find the time, or touch the general area
+# for other purposes, please consider removing their uses.
+
+# It might be possible to consolidate hard_reset() to southbridges,
+# given that it (usually) uses its registers.
+# The long term goal would be to eliminate hard_reset from boards.
+config BOARD_HAS_HARD_RESET
+        bool
+        default n
+        help
+          This variable specifies whether a given board has a reset.c
+          file containing a hard_reset() function.
+
+# It might be possible to consolidate FADTs to southbridges. This would
+# improve code reuse in the tree.
+config BOARD_HAS_FADT
+        bool
+        default n
+        help
+          This variable specifies whether a given board has a board-local
+          FADT in fadt.c. Long-term, those should be moved to appropriate
+          chipset components (eg. southbridge)
+
+# There ought to be a better place to put data than code. Also, make this
+# (or a similar) framework more universally usable, so all boards benefit
+# from sharing data between the various tables.
+config HAVE_BUS_CONFIG
+        bool
+        default n
+	help
+	  This variable specifies whether a given board has a get_bus_conf.c
+	  file containing information about bus routing.




More information about the coreboot mailing list