[coreboot] [PATCH]better testing for dependencies of coreboot.rom

Patrick Georgi patrick at georgi-clan.de
Tue Mar 16 16:54:26 CET 2010


attached patch improves dependency tracking for coreboot.rom. make isn't
particularily reliable with deleting files after their rules failed (and
I'm not sure if this is a requirement, though some versions of make do it).
So if you build coreboot and forgot to put the payload at the right
spot, the next make run (after adding the payload) will not redo
coreboot.rom as coreboot.rom already exists.

This patch attacks this issue from two sides:
1. adds the files to add as dependencies of coreboot.rom, so make stops
before starting to work on coreboot.rom

2. creates coreboot.rom as coreboot.rom.tmp and renames the result after
all write operations succeeded. This helps should any of the operations
fail (eg. because the ELF parser in cbfstool is confused by the input file)

Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 20100316-4-better-dependency-testing-for-coreboot.rom.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100316/9105050d/attachment.ksh>

More information about the coreboot mailing list