[coreboot] [PATCH]Remove fallback/normal decision from mainboards' romstage.c

Patrick Georgi patrick at georgi-clan.de
Thu Mar 18 17:28:39 CET 2010

Am 18.03.2010 17:23, schrieb Peter Stuge:
>> +	if (!((cpu_init_detectedx) || (!boot_cpu()))) {
>> +		/* Nothing special needs to be done to find bus 0 */
>> +		/* Allow the HT devices to be found */
>> +		enumerate_ht_chain();
>> +		/* sb600_lpc_port80(); */
>> +		sb600_pci_port80();
> This is a recurring pattern with both sb600 and sb700. Is there a
> reason to duplicate that call in a comment or could the comment just
> be removed?
This was a mechanical refactoring without looking in-depth at such
issues. (all that code existed before)
I guess these two calls configure where port 80 writes go, and the
comment is basically documentation how to move port 80 to the LPC bus.

There might be ways to refactor such code, but that requires a more
global view.

>> --- src/mainboard/amd/mahogany/cache_as_ram_auto.c	(revision 5256)
> Where did this code go?
src/mainboard/amd/mahogany/romstage.c already exists and is nearly
identical, except for an additional bugfix.


More information about the coreboot mailing list