[coreboot] W83977EF vs. ASUS P2B-L vs. PS/2 keyboard

[Keith Hui]

> Message: 9
> Date: Tue, 23 Mar 2010 14:19:01 -0600
> From: Myles Watson <mylesgw at gmail.com>
> To: ron minnich <rminnich at gmail.com>
> Cc: Mark Marshall <mark.marshall at csr.com>, coreboot at coreboot.org
> Subject: Re: [coreboot] W83977EF vs. ASUS P2B-L vs. PS/2 keyboard
> Message-ID:
>        <2831fecf1003231319v303e3ac3r1d03e2d2bc1c28aa at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
>> 155                     pnp_set_logical_device(dev);
>> > 156                     pnp_set_enable(dev, 1);
>>
>
> This little snippet looks a lot like pnp_enable_resources, which is already
> getting called on all enabled devices.
>
> Maybe it's not getting called early enough?
>
> Thanks,
> Myles

Indeed. Any room for simplification?

http://tracker.coreboot.org/trac/coreboot/browser/trunk/src/devices/device.c

Line 801. This is very suspicious too. Shouldn't it be returning only
if it is ALREADY enabled?

My log points to only PCI devices getting enabled. Could this be the
root culprit?

I'll see what happens if I change this instead of applying the patch I
just floated.

Thanks
Keith