[coreboot] [commit] r5319 - trunk/src/arch/i386/include/arch
mylesgw at gmail.com
Tue Mar 30 00:43:16 CEST 2010
On Mon, Mar 29, 2010 at 4:40 PM, Stefan Reinauer <stepan at coresystems.de>wrote:
> On 3/30/10 12:35 AM, Stefan Reinauer wrote:
> On 3/30/10 12:15 AM, Myles Watson wrote:
> Modified: trunk/src/arch/i386/include/arch/pirq_routing.h
>> --- trunk/src/arch/i386/include/arch/pirq_routing.h Mon Mar 29
>> 23:56:26 2010 (r5318)
>> +++ trunk/src/arch/i386/include/arch/pirq_routing.h Tue Mar 30
>> 00:05:26 2010 (r5319)
>> @@ -18,9 +18,8 @@
>> #if defined(CONFIG_IRQ_SLOT_COUNT)
>> #define IRQ_SLOTS_COUNT CONFIG_IRQ_SLOT_COUNT
>> -#elif (__GNUC__ < 3)
>> -#define IRQ_SLOTS_COUNT 1
>> +#warning "No IRQ_SLOT_COUNT in Kconfig."
>> #define IRQ_SLOTS_COUNT
>> I think we should get rid of IRQ_SLOTS_COUNT and move the error into
> Kconfig. The added warning is very similar to one in pirq_routing.c
> I like that much better... do you have a patch in mind?
> Hm.. how do we error in Kconfig? Is there a way to do that at all? I think
> we didn't use this before...
I was thinking about making HAVE_PIRQ_TABLE depend on CONFIG_IRQ_SLOT_COUNT
Then when someone ported Coreboot to a board they'd set it correctly. We
could tell from abuild results how many boards have HAVE_PIRQ_TABLE set and
> Should we drop the whole block of code in pirq_routing.h and make it an
> #error in pirq_routing.c?
I guess it depends on how many boards it breaks.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the coreboot