[coreboot] [PATCH] make AMD CAR disable a C function

Patrick Georgi patrick at georgi-clan.de
Sun May 16 21:55:58 CEST 2010


Am 16.05.2010 19:50, schrieb Kevin O'Connor:
> The AMD disable_cache_as_ram can be C code, but the other
> architectures can not.  It would be nice if there was a single calling
> convention for this capability across architectures.
Good idea!


> void romstage(u32 bist) {
>     ...
>     disable_car(load_ramstage, bist, CONFIG_RAMTOP)
> }
Where would this code reside? Hopefully not (in this verbosity) in every
boards' romstage.c?

load_ramstage and the new stack location shouldn't be board specific
(and shouldn't need to be). With both pretty much set in stone, only
bist needs to be brought over.


Regards,
Patrick




More information about the coreboot mailing list