[coreboot] [PATCH] Improve i82830 MBI SMI Handler

Peter Stuge peter at stuge.se
Fri May 21 18:27:55 CEST 2010


Joseph Smith wrote:
> This patch improves the i82830 MBI SMI Handler. It is now able to load 
> Intel vbios VBT and Flexaim modules. Build and boot tested.
>
> Signed-off-by: Joseph Smith <joe at settoplinux.org>

One issue, but other than that it is

Acked-by: Peter Stuge <peter at stuge.se>


> +++ src/northbridge/intel/i82830/i82830_smihandler.c	(working copy)
> @@ -32,7 +32,7 @@
>  extern unsigned char *mbi;
>  extern u32 mbi_len;
>  
> -// #define DEBUG_SMI_I82830
> +#define DEBUG_SMI_I82830

Really enable debugging here by default? Should this maybe come from
Kconfig somehow. It could e.g. depend on some existing value in
Kconfig.


//Peter




More information about the coreboot mailing list