[coreboot] Fam10 error

Myles Watson mylesgw at gmail.com
Fri May 21 19:17:09 CEST 2010


On Fri, May 21, 2010 at 11:08 AM, Marc Jones <marcj303 at gmail.com> wrote:
> It should be initialized to 0. The !nb_cof_vid_update would mean that
> the fidmax shouldn't change so the value isn't important, but 0 would
> be the safest if there is another hole in the logic and CPUs are not
> matched
.
Rev 5577.

Thanks,
Myles

> On Fri, May 21, 2010 at 9:41 AM, Myles Watson <mylesgw at gmail.com> wrote:
>> coreboot-builds/amd_mahogany_fam10/make.log:src/cpu/amd/model_10xxx/fidvid.c:758:
>> warning: 'fid_max' may be used uninitialized in this function

>> So we send garbage to the BSP for fid_max of the AP.  What should we
>> be sending instead if !nb_cof_vid_update?




More information about the coreboot mailing list