[coreboot] [PATCH]Move SET_FIDVID* to Kconfig

Patrick Georgi patrick at georgi-clan.de
Sat Nov 6 13:56:45 CET 2010


I moved the SET_FIDVID family of configuration options to Kconfig,
adapting its use (CONFIG_ prefix), and tried to minimize the board
specific settings.

They get some defaults in src/cpu/amd/model_*xx/Kconfig, which are
derived from the various #ifndef ... #define ... #endif blocks I removed
in the cpu specific code.

All "#define SET_FIDVID 0" in romstage.c files weren't necessary due to
these defaults, as well as all "#define SET_FIDVID 1" in Fam10 boards,
so these were stripped.
Some "select SET_FIDVID" could probably still be removed.

SET_FIDVID_CORE_RANGE was always 0, so I just chose that in the CPU
config, instead of per-board.
SET_FIDVID_CORE0_ONLY was always 1, so again, I moved this to the CPU.

Any change in SET_FIDVID* configuration values as a result of this patch
is a bug in this patch.


Move SET_FIDVID family of configuration options to Kconfig.
Reduce their per-board use and rely on per-cpu values instead.

Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 20101106-1-move-set-fidvid-to-Kconfig.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20101106/e169c494/attachment.ksh>

More information about the coreboot mailing list