[coreboot] [PATCH] Some more DIMM0 related cleanups and deduplication
patrick at georgi-clan.de
Sat Nov 20 21:07:05 CET 2010
Am 20.11.2010 21:00, schrieb Uwe Hermann:
> Some more DIMM0 related cleanups and deduplication.
> - VIA VT8235: Do the shift in smbus_read_byte() as all other chipsets do.
> - spd.h: Move RC00-RC63 #defines here, they were duplicated in lots of
> romstage.c files and lots of spd_addr.h files. Don't even bother for
> those spd_addr.h which aren't even actually used, drop them right away.
> - Replace various 0x50 hardcoded numbers with DIMM0, 0x51 with DIMM1,
> and 0xa0 with (DIMM0 << 1) where appropriate.
> - Various debug.c files: Replace SMBUS_MEM_DEVICE_START with DIMM0,
> SMBUS_MEM_DEVICE_END with DIMM7, and drop useless SMBUS_MEM_DEVICE_INC.
> - VIA VX800: Drop unused SMBUS_ADDR_CH* #defines.
> - VIA VT8623: Do the shift in smbus_read_byte() as all other chipsets do.
> Then, replace 0xa0 (which now becomes 0x50) with DIMM0.
> - alix1c/romstage.c, alix2d/romstage.c: Adapt to recent bit shift changes.
> - Various files: Drop DIMM_SPD_BASE and/or replace it with DIMM0.
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
Acked-by: Patrick Georgi <patrick at georgi-clan.de>
I really like where this is heading (and it also fixes a couple of bugs
my patch introduced *blush*)
More information about the coreboot