[coreboot] [PATCH] Unify the Socket 940 CAR configuration.

Warren Turkal wt at penguintechs.org
Fri Oct 1 10:15:53 CEST 2010

Notice that it is also changing the base of the CAR area and, in some
cases, the size of the global variable region. Should I be worried
about those?


On Thu, Sep 30, 2010 at 2:58 PM, Myles Watson <mylesgw at gmail.com> wrote:
>> I am looking for some comments on the following patch. It unifies the
>> socket 940 cache-as-ram implementation. Previously, the affected boards
>> had their own CAR options in their Kconfig files. There is a default set
>> of CAR configs in the socket.
>> Does anyone have comments on why this patch should or should not be
>> committed?
> Pro:
> It's simpler.
> Con:
> It probably slows booting a little, since there's more stack to copy.  I
> have no idea how much.
> The code handles either CAR size already, so it shouldn't break anything.
> Thanks,
> Myles

More information about the coreboot mailing list