[coreboot] [PATCH] Factor out common CAR asm snippets

Peter Stuge peter at stuge.se
Fri Oct 1 23:39:53 CEST 2010

Uwe Hermann wrote:
> Factor out common CAR asm snippets.
> This makes the CAR implementations a lot more readable, shorter and
> easier to follow, and also reduces the amount of uselessly duplicated code.
> For example there are more than 12 open-coded "enable cache" instances
> spread all over the place (and 12 "disable cache" ones), multiple
> "enable mtrr", "save BIST", "restore BIST", etc. etc.
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>

Nice! I would kill some blank lines too, but this is a really nice 
improvement either way!

Acked-by: Peter Stuge <peter at stuge.se>

More information about the coreboot mailing list