[coreboot] [PATCH] Factor out common CAR asm snippets
wt at penguintechs.org
Sat Oct 2 21:27:58 CEST 2010
I think that making arguments against this code on grounds that it
doesn't feel like other common code is a little shortsighted. When
bugs are fixed in one bit of code, we should be able to take advantage
of those in other parts of code. For instance, I just had to
copy/paste some CPP logic to fix the via/vt8454c CAR init due to a
tiny bootblock. That would have already been fixed had the via and amd
logic been unified since they are basically identical bits of code.
On Sat, Oct 2, 2010 at 12:10 PM, Peter Stuge <peter at stuge.se> wrote:
> ron minnich wrote:
>> I find the non-abstracted version much easier to understand.
> FWIW I think write-once makes it even nicer to have high-level
> operations in source code. Since it will change less often (ie. be
> less well known) it's a good thing to not need to see every detail
> the next time it is looked at.
> It seems me and Uwe just can not win this. Too bad.
> coreboot mailing list: coreboot at coreboot.org
More information about the coreboot