[coreboot] PCI register read/mod/write code

ron minnich rminnich at gmail.com
Mon Oct 4 01:35:09 CEST 2010


On Sun, Oct 3, 2010 at 4:10 PM, Peter Stuge <peter at stuge.se> wrote:
> Rudolf just found a bug in the sb700 code:
>
> u32 dword;
> ..
> dword = pci_read_config8(dev, 0x64);
> dword |= 1 << 10;
> pci_write_config8(dev, 0x64, dword);
>

but why wouldn't the compiler warn about using a dword where a u8 is required?


void pci_write_config8(device_t dev, unsigned where, uint8_t val)

There's no warning of any kind?

ron




More information about the coreboot mailing list