[coreboot] PCI register read/mod/write code

Myles Watson mylesgw at gmail.com
Mon Oct 4 22:02:12 CEST 2010


On Sun, Oct 3, 2010 at 5:10 PM, Peter Stuge <peter at stuge.se> wrote:
> Rudolf just found a bug in the sb700 code:
>
> u32 dword;
> ..
> dword = pci_read_config8(dev, 0x64);
> dword |= 1 << 10;
> pci_write_config8(dev, 0x64, dword);
>
>
> And I'm ranting now, because a pci_set8() macro/function could have
> found this bug at compile time, and because I don't like these
> constructs. (Compiler warnings would also have indicated a problem.
> They're currently disabled for this code.)

How and where are compiler warnings disabled for this code?

Thanks,
Myles




More information about the coreboot mailing list