[coreboot] [PATCH]De-define CK804 flags

Myles Watson mylesgw at gmail.com
Tue Oct 5 20:01:51 CEST 2010


On Tue, Oct 5, 2010 at 11:16 AM, Patrick Georgi <patrick at georgi-clan.de> wrote:
> Am 05.10.2010 17:32, schrieb Myles Watson:
>> On Tue, Oct 5, 2010 at 8:41 AM, Patrick Georgi <patrick at georgi-clan.de> wrote:
>>> Hi,
>>>
>>> attached patch moves a couple more config flags out of romstage:
>>> CK804_USE_NIC, CK804_USE_ACI.
>>>
>>> Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
>> Acked-by: Myles Watson <mylesgw at gmail.com>
>>
>> I'd like to keep CK804 & MCP55 as similar as possible.  Patches attached.
> Acked-by: Peter Stuge <peter at stuge.se>
Rev 5912.

> One issue: you didn't handle all MCP55_NUMs, there are some #defines
> left.
I didn't see any, but I'll fix them if you point them out.

> I didn't work on the _NUM stuff at all as I don't know its meaning.
It is how many chips there are on the board.  Most boards only have
one CK804 or MCP55, but some have two.

Thanks,
Myles




More information about the coreboot mailing list