[coreboot] [PATCH] Reduce duplicate definition in CAR code.

Warren Turkal wt at penguintechs.org
Tue Oct 5 21:49:57 CEST 2010


Is that an Ack? If so, I will work on a more serious patch that does
this for all car implementations and moves the lists to a header.

I am thinking of using a macro like MTRR_ADDR_LIST_ASM in the header.
What do you think about that? I don't want it to look like a function
call. What do you think about that?

Thanks,
wt

On Tue, Oct 5, 2010 at 8:36 AM, ron minnich <rminnich at gmail.com> wrote:
> On Tue, Oct 5, 2010 at 3:00 AM, Warren Turkal <wt at penguintechs.org> wrote:
>> Here is a patch that I feel improves the readability of the CAR code a
>> little bit. What do you all think?
>
>
> I think it's quite nice, as you replace mysterious numbers with a
> meaningful name.
>
> ron
>
> --
> coreboot mailing list: coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
>




More information about the coreboot mailing list