[coreboot] [PATCH try 4] Reduce duplicate definition in CAR code.

ron minnich rminnich at gmail.com
Thu Oct 7 17:50:49 CEST 2010

On Thu, Oct 7, 2010 at 5:58 AM, Kevin O'Connor <kevin at koconnor.net> wrote:

> Just my $0.02 - I like how you've replaced the magic numbers with
> names.  I don't like how you've moved the lists to another file.
> My suggestion would be to replace all the magic numbers in the
> assembler files.  Then once that's complete, send patches with your
> proposal to change the assembler layout.
> BTW, the list concept doesn't make much sense anyway - at least on
> Via, there is no need to clear the fixed mtrrs, and you don't need a
> list to clear the variable mtrrs (a simple iterator would suffice).

Agree on all points ...


More information about the coreboot mailing list