[coreboot] [PATCH] Convert Intel 82371AB/EB/MB boards to TINY_BOOTBLOCK

Uwe Hermann uwe at hermann-uwe.de
Thu Oct 7 19:33:33 CEST 2010

On Thu, Oct 07, 2010 at 09:20:58AM -0700, Stefan Reinauer wrote:
> Acked-by: Stefan Reinauer <stepan at coresystems.de>

Thanks, r5918.

> > +	dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_INTEL,
> > +				       PCI_DEVICE_ID_INTEL_82371AB_ISA), 0);
> > +
> Does it make sense to use pci_locate_device_on_bus() here instead? Well,
> maybe not because we start on bus 0 and the device is always there.
> Maybe it's kind of too philosophical to distinguish.

Hm, dunno. Maybe it saves some microseconds during boot or makes the
image slightly smaller? In that case it might make sense, but otherwise
it probably doesn't matter much.

http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org

More information about the coreboot mailing list