[coreboot] [PATCH] Kconfig fixes & RAMINIT_SYSINFO

Uwe Hermann uwe at hermann-uwe.de
Fri Oct 8 00:56:36 CEST 2010


On Thu, Oct 07, 2010 at 03:55:41PM -0600, Myles Watson wrote:
> Kconfig_if.diff : use if instead of depends on to avoid typos
> socket_type.diff : don't define socket_type and dimm_type when they aren't used
> raminit_sysinfo.diff : get rid of another define
> 
> Signed-off-by: Myles Watson <mylesgw at gmail.com>

Looks good to me.

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


> Index: svn/src/northbridge/amd/amdk8/Kconfig
> ===================================================================
> --- svn.orig/src/northbridge/amd/amdk8/Kconfig
> +++ svn/src/northbridge/amd/amdk8/Kconfig
> @@ -24,45 +24,40 @@ config NORTHBRIDGE_AMD_AMDK8
>  	select HAVE_DEBUG_CAR
>  	select HYPERTRANSPORT_PLUGIN_SUPPORT
>  
> +if NORTHBRIDGE_AMD_AMDK8
>  config AGP_APERTURE_SIZE
>  	hex
>  	default 0x4000000
> -	depends on NORTHBRIDGE_AMD_AMDK8
>  
>  config K8_HT_FREQ_1G_SUPPORT
>  	bool
>  	default n
> -	depends on NORTHBRIDGE_AMD_AMDK8
>  
>  config MEM_TRAIN_SEQ
>  	int
>  	default 0
> -	depends on NORTHBRIDGE_AMD_AMDK8
>  
>  config HW_MEM_HOLE_SIZEK
>  	hex
>  	default 0x100000
> -	depends on NORTHBRIDGE_AMD_AMDK8
>  
>  config HW_MEM_HOLE_SIZE_AUTO_INC
>  	bool
>  	default n
> -	depends on NORTHBRIDGE_AMD_AMDK8
>  
>  config SB_HT_CHAIN_UNITID_OFFSET_ONLY
>  	bool
>  	default n
> -	depends on NORTHBRIDGE_AMD_AMDK8
> +
> +if K8_REV_F_SUPPORT
>  
>  config DIMM_DDR2
>  	bool
>  	default n
> -	depends on NORTHBRIDGE_AMD_AMDFAM10
>  
>  config DIMM_REGISTERED
>  	bool
>  	default n
> -	depends on NORTHBRIDGE_AMD_AMDFAM10

Is this the "prevent typos" you refer to above, i.e., the
variables in amdk8/Kconfig depending on Fam10h?

If not, how does K8_REV_F_SUPPORT relate to NORTHBRIDGE_AMD_AMDFAM10?


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org




More information about the coreboot mailing list