[coreboot] [PATCH] Remove various .c #includes from Intel 440BX/82371EB boards

Corey Osgood corey.osgood at gmail.com
Fri Oct 8 08:41:40 CEST 2010


On Thu, Oct 7, 2010 at 5:50 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> See patch.
>
> This works fine (tested in abuild) for all 440BX boards, but it seems to
> break the build of the QEMU target.
>
> I tried to fix it but I don't really know how it can be done. The
> problem is (I guess) that the QEMU target is still using ROMCC and
> all other 82371EB boards don't (?) Any ideas?
>
>    CC         southbridge/intel/i82371eb/i82371eb_early_smbus.romstage.o
>    GEN        romstage/ldscript.ld
>    LINK       coreboot.romstage
> build/southbridge/intel/i82371eb/i82371eb_early_pm.romstage.o: In function `enable_pm':
> /home/uwe/v4_remove_c/src/southbridge/intel/i82371eb/i82371eb_early_pm.c:42: undefined reference to `die'
> build/southbridge/intel/i82371eb/i82371eb_early_smbus.romstage.o: In function `enable_smbus':
> /home/uwe/v4_remove_c/src/southbridge/intel/i82371eb/i82371eb_early_smbus.c:47: undefined reference to `die'
> collect2: ld returned 1 exit status
> make: *** [build/coreboot.romstage] Error 1
>

I think I've found the problem, include/console/console.h:

62 #ifndef __ROMCC__
63 void console_init(void);
64 void post_code(u8 value);
65 void __attribute__ ((noreturn)) die(const char *msg);

Maybe move that definition a few lines up, and see what happens? Or
else converting the QEMU target to CAR seems like the other option.

-Corey



>
> Uwe.
> --
> http://hermann-uwe.de     | http://sigrok.org
> http://randomprojects.org | http://unmaintained-free-software.org
>
> --
> coreboot mailing list: coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
>




More information about the coreboot mailing list