[coreboot] [PATCH] Remove various .c #includes from Intel 440BX/82371EB boards

Uwe Hermann uwe at hermann-uwe.de
Sat Oct 9 12:04:06 CEST 2010

On Fri, Oct 08, 2010 at 02:41:40AM -0400, Corey Osgood wrote:
> I think I've found the problem, include/console/console.h:
> 62 #ifndef __ROMCC__
> 63 void console_init(void);
> 64 void post_code(u8 value);
> 65 void __attribute__ ((noreturn)) die(const char *msg);
> Maybe move that definition a few lines up, and see what happens? Or

So far I couldn't find a combination which works, but it's not needed at
the moment, I can dodge the problem by removing the die() calls
alltogether, that was on my TODO list anyways. Those checks in the code
are not really useful, the PCI device is always there, and we don't do
such checks elsewhere in the code either.

Updated patch attached, now survives abuild.

> else converting the QEMU target to CAR seems like the other option.

That won't work as far as I've heard (QEMU limitations).

http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4_remove_c_includes_i82371eb_2.patch
Type: text/x-diff
Size: 30966 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20101009/40969477/attachment.bin>

More information about the coreboot mailing list