[coreboot] [PATCH] Fix bootswitch of SATA/PATA

Warren Turkal wt at penguintechs.org
Mon Oct 11 08:14:15 CEST 2010


On Sun, Oct 10, 2010 at 12:05 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
*snip*

>> ===================================================================
>> --- sb700_ide.c       (revision 5917)
>> +++ sb700_ide.c       (working copy)
>> @@ -52,10 +53,13 @@
>>
>>       /* set ide as primary, if you want to boot from IDE, you'd better set it
>>        * in $vendor/$mainboard/devicetree.cb */
>> +
>> +
>>       if (conf->boot_switch_sata_ide == 1) {
>> -             byte = pci_read_config8(dev, 0xAD);
>> +             struct device *sm_dev = dev_find_slot(0, PCI_DEVFN(0x14, 0));
>
> I personally don't like the "struct device *sm_dev" to be defined here,
> please consider putting it at the beginning of the function, not in the
> middle (yeah, I know, it works, I just don't like it much).

Doesn't declaring the struct there mean that it's only available
within that block's scope? Is there any reason to declare the var
outside that block if that's the only place where the var is used?

Thanks,
wt




More information about the coreboot mailing list