[coreboot] [PATCH] coreboot: fix typo after r5925

Uwe Hermann uwe at hermann-uwe.de
Tue Oct 12 01:26:28 CEST 2010

Hi Sylvain,

please always reply to the mailing list, not individual developers. The
"reply all" button in your mail client should do the right thing.

On Sun, Oct 10, 2010 at 07:08:39PM +0200, Sylvain 'ythier' Hitier wrote:
> Hello,
> Here is an untested patch, but I feel enough confident with C.
> Regards,
> Sylvain "ythier" Hitier
> ========
> Fix typo after r5925.
> BTW, embed the always-the-same string instead of referencing it through "%s".
> Signed-off-by: Sylvain Hitier <sylvain.hitier at gmail.com>

Thanks, committed in r5940 with a small change, I only moved
"IDE interface" into the string, which should save a little bit of
space in the ROM (as the strings for primary and secondary are
now identical, except for the contents of %s).

I also did the same micro-optimization in i82371EB.

http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org

More information about the coreboot mailing list