[coreboot] [patch] superiotool NetBSD support

Jonathan A. Kollasch jakllsch at kollasch.net
Mon Oct 18 15:42:48 CEST 2010


On Sun, Oct 17, 2010 at 10:51:06PM -0700, Warren Turkal wrote:
> On Sunday, October 17, 2010 07:39:06 am Jonathan A. Kollasch wrote:
> > Provide for I/O space access on NetBSD.
> > 
> > Signed-off-by: Jonathan Kollasch <jakllsch at kollasch.net>
> > ---
> 
> It might be better to use "inline" instead of "__inline" and define a macro to 
> use the real name you want on certain platorms since c99 reserves the keyword 
> "inline" for this purpose.

Well, the Makefile gives the compiler -ansi ...

> Having said that, do those functions really need to be inlined?

Maybe, they aren't used that much, and may as well flow right into
the code IMO.

	Jonathan Kollasch




More information about the coreboot mailing list