[coreboot] [patch] 6300ESB early smbus cleanup

Jonathan A. Kollasch jakllsch at kollasch.net
Mon Oct 18 17:25:31 CEST 2010


Remove unused variables from 6300ESB smbus_write_block().

#if 0 smbus_write_byte() and smbus_write_block() as they are
static and nothing uses them or are incompletely implemented.

Signed-off-by: Jonathan Kollasch <jakllsch at kollasch.net>
---
-------------- next part --------------
Index: src/southbridge/intel/esb6300/esb6300_early_smbus.c
===================================================================
--- src/southbridge/intel/esb6300/esb6300_early_smbus.c	(revision 5965)
+++ src/southbridge/intel/esb6300/esb6300_early_smbus.c	(working copy)
@@ -22,6 +22,7 @@
 	return do_smbus_read_byte(SMBUS_IO_BASE, device, address);
 }
 
+#if 0
 static void smbus_write_byte(unsigned device, unsigned address, unsigned char val)
 {
 	if (smbus_wait_until_ready(SMBUS_IO_BASE) < 0) {
@@ -33,8 +34,6 @@
 static int smbus_write_block(unsigned device, unsigned length, unsigned cmd,
 		 unsigned data1, unsigned data2)
 {
-	unsigned char global_control_register;
-	unsigned char global_status_register;
 	unsigned char byte;
 	unsigned char stat;
 	int i;
@@ -95,4 +94,5 @@
 	print_debug("SMBUS Block complete\n");
 	return 0;
 }
+#endif
 


More information about the coreboot mailing list