[coreboot] [patch] 6300ESB early smbus cleanup

Peter Stuge peter at stuge.se
Mon Oct 18 21:17:06 CEST 2010


Jonathan A. Kollasch wrote:
> Remove unused variables from 6300ESB smbus_write_block().
> 
> #if 0 smbus_write_byte() and smbus_write_block() as they are
> static and nothing uses them or are incompletely implemented.

Why #if 0 rather than just removing the code completely? I think this
is a piece of code which can already be found other places if a
reference is needed?

> Signed-off-by: Jonathan Kollasch <jakllsch at kollasch.net>

Acked-by: Peter Stuge <peter at stuge.se>




More information about the coreboot mailing list