[coreboot] [patch] inteltool support for FreeBSD

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Oct 20 12:36:40 CEST 2010


On 20.10.2010 10:07, Warren Turkal wrote:
> On Mon, Oct 18, 2010 at 7:26 AM, Idwer Vollering <vidwer at gmail.com> wrote:
>   
>> Is this a possible memory leak ? If so, it needs to be fixed in flashrom
>> too.
>>     
>
> It would only be a memory leak if used in a long running process that
> doesn't use the file over and over. As it stands, the OS will reclaim
> the memory used to create the file descriptor when the process ends,
> and I am not sure there's much practical point in closing the file.
> However academically, the file probably should be closed.
>   

AFAIK flashrom does close all file descriptors, even those used for
device I/O on some BSDs.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list