[coreboot] [patch] F71806/F71872 for superiotool

[Uwe Hermann]

On Fri, Oct 22, 2010 at 01:04:52AM +0000, Jonathan A. Kollasch wrote:
> Teach superiotool about the registers in a Fintek F71806 (and F71872).
> 
> Signed-off-by: Jonathan Kollasch <jakllsch at kollasch.net>

Looks good, I verified against the F71872F/FG and F71806F/FG datasheets,
some minor suggestions below.


> Index: util/superiotool/fintek.c
> ===================================================================
> --- util/superiotool/fintek.c	(revision 5978)
> +++ util/superiotool/fintek.c	(working copy)
> @@ -77,6 +77,42 @@
>  			{0x00,0x00,NANA,0x06,0x1c,0x01,EOT}},
>  		{EOT}}},
>  	{0x4103, "F71872F/FG / F71806F/FG", {	/* Same ID? Datasheet typo? */
> +		{NOLDN, NULL,
> +			{0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27,0x28,
> +			 0x29,0x2a,0x2b,0x2c,0x2d,EOT},
> +			{0x03,0x41,RSVD,0x19,0x34,0x00,0x00,0x00,0x66,
> +			 0x80,0x00,0x00,0x00,0x04,EOT}},

0x27 should be "MISC", not 0x00, as it contains one bit that can be
non-zero, depending on hardware straps I think.



> +		{0x5, "Keyboard",
> +			{0x30,0x60,0x61,0x70,0x72,0xf0,EOT},
> +			{0x01,0x00,0x60,0x00,0x00,0x83,EOT}},

Yup, good choice. LDN 5 is not listed in the F71806F/FG datasheet
(marked "reserved") but it is documented in the F71872F/FG datasheet.
As the IDs of the two chips are identical (at least according to
the datasheets) so we cannot easily detect which of both chips we have,
so we should add LDN 5 indeed.

However, please add the 0xf1 register (KBC Test Mode Register) with a
default value of 0x00, that's listed in the datasheet.

With the above changes:
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


Please also post the output of "superiotool -d" on your board and
mention which of the two possible Super I/Os is actually soldered onto
your board. Maybe the identical IDs are indeed just typos in the
datasheet?


Thanks, Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org