[coreboot] [PATCH] Debugging facility improvements
Peter Stuge
peter at stuge.se
Tue Oct 26 07:19:59 CEST 2010
Uwe Hermann wrote:
> > > Debugging facility improvements.
> > >
> > > - Hook up malloc() debug code via CONFIG_DEBUG_MALLOC.
..
> > > +++ src/Kconfig (Arbeitskopie)
> > > @@ -553,6 +553,16 @@
> > >
> > > If unsure, say N.
> > >
> > > +config DEBUG_MALLOC
> > > + bool "Output verbose malloc debug messages"
> > > + default n
> > > + help
> > > + This option enables additional malloc related debug messages.
> > > +
> > > + Note: This option will increase the size of the coreboot image.
> > > +
> > > + If unsure, say N.
> >
> > Should this also force debug level to SPEW?
>
> No idea, but it's unrelated to this patch.
I disagree.
> As far as I can see all other such DEBUG_* mechanisms don't force
> the debug level to SPEW either, so if we want to do that (I'm not
> sure we do) that's material for another patch.
My point is that the patch claims to improve debugging, but in fact
it adds the possibility that a user creates a configuration where
they expect malloc debug messages but in fact do not get any because
there is a glitch in Kconfig between the option they enabled and the
requirement in code for SPEW loglevel for that option to have any
effect. I don't think we should accept glitches like that, it is
potentially a huge waste of time for the user, as well as extremely
annoying. It makes coreboot look really unprofessional. :\
//Peter
More information about the coreboot
mailing list