[coreboot] [PATCH] Remove incorrect IOAPIC lines from some mptable.c files

Jonathan A. Kollasch jakllsch at kollasch.net
Sun Oct 31 20:12:43 CET 2010


On Fri, Oct 29, 2010 at 10:41:07PM +0200, Uwe Hermann wrote:
> See patch.
> 
> 
> Uwe.
> -- 
> http://hermann-uwe.de     | http://sigrok.org
> http://randomprojects.org | http://unmaintained-free-software.org

> Remove incorrect IOAPIC lines from some mptable.c files.
> 
>  - via/epia-n/mptable.c
>  - intel/eagleheights/mptable.c (commented out anyway)
>  - asus/p2b-d/mptable.c
>  - asus/p2b-ds/mptable.c
> 
> Some files still incorrectly contain some smp_write_ioapic() lines from
> the original mptable utility target (Supermicro P4DPE), which has one
> IOAPIC in the southbridge (Intel ICH3-S), two IOAPICs contained in
> the first P64H2, and two more in the second P64H2, i.e. 5 IOAPICs in total.
> 
> However, none of the boards where this chunk of code is present has
> multiple IOAPICs (and even if they had, the PCI devices where those are
> located would probably be different anyway), so drop the incorrect
> mptable.c contents.
> 
> Also drop the lines from the mptable utility, so that future mptable.c files
> don't incorrectly inherit any of this stuff.
> 
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
> 

Acked-by: Jonathan Kollasch <jakllsch at kollasch.net>




More information about the coreboot mailing list