[coreboot] [PATCH] fix 'AMD Fam10 code breaks with gcc 4.5.0'

Scott scott at notabs.org
Thu Sep 2 23:03:35 CEST 2010

Signed-off-by: Scott Duplichan <scott at notabs.org>

The attached patch allows the use of gcc 4.5.0 for AMD builds.
The AMD Tilapia BIOS built with gcc 4.5.0 and this patch has
passed testing on the simnow target only. Can someone confirm
that the attached patch allows an AMD family 10h BIOS such as
Tilapia to work on real hardware? At the same time I will try
to get the change tested on real hardware.

Root cause: After function STOP_CAR_AND_CPU disables cache as
ram, the cache as ram stack can no longer be used. Called 
functions must be inlined to avoid stack usage. Also, the
compiler must keep local variables register based and not
allocated them from the stack. With gcc 4.5.0, some functions
declared as inline are not being inlined. This patch forces
these functions to always be inlined by adding the qualifier
__attribute__((always_inline)) to their declaration.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: amd-gcc-450.patch
Type: application/octet-stream
Size: 1251 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100902/976d15a3/attachment.obj>

More information about the coreboot mailing list