[coreboot] [PATCH] libpayload: scan all PCI functions for USB

Patrick Georgi patrick at georgi-clan.de
Fri Sep 3 16:55:15 CEST 2010

Am 03.09.2010 16:44, schrieb Jens Rottmann:
> The AMD CS5536's USB controllers are located at device 0F, functions 4
> and 5.  They're not found if only function 0 is checked.  So if a device
> exists at all, try all its functions.  usb_controller_initialize() will
> silently skip all device classes != 0C03.
Oh my.. I suppose that's technically legal. *sigh*
Good catch!

I kept the access at 32bit, as this is not a 16bit value, and somewhere
hidden in some addendum to some obscure PCI standard they certainly
require 32bit accesses, with some hardware out there probably relying on
conformance to that.
If the 32bit access is actually an issue for your hardware, please note
so and we can try the change.

> Signed-off-by: Jens Rottmann <JRottmann at LiPPERTEmbedded.de>
Acked-by: Patrick Georgi <patrick.georgi at coresystems.de>

and committed in r5774


More information about the coreboot mailing list