[coreboot] [PATCH] AMD MMCONF Support

Myles Watson mylesgw at gmail.com
Mon Sep 13 17:15:47 CEST 2010


On Mon, Sep 13, 2010 at 6:52 AM, Myles Watson <mylesgw at gmail.com> wrote:
>
>> Arne Georg Gleditsch <arne.gleditsch at numascale.com> writes:
>> > With this change, I can re-insert the RES_PCI_IO wihtout ill effects.
>>
>> Move initialization of MMCONF BAR to cache_as_ram setup phase, in order
>> to make sure MMCONF is set up before use.  Otherwise, PCI config
>> accesses run before init_cpus() will be lost if MMCONF is enabled
>> (unless explicitly done as port-based accesses).
>>
>> This obsoletes removal of RES_PCI_IO, PCI_ADDR(0, 1, 0, 0x78) in
>> mcp55_early_setup, so reinsert.
>>
>> Signed-off-by: Arne Georg Gleditsch <arne.gleditsch at numascale.com>
>
> Acked-by: Myles Watson <mylesgw at gmail.com>
Rev 5810.

Arne:
Could you help me understand MMCONF_SUPPORT and
MMCONF_SUPPORT_DEFAULT?  It looks like the area gets reserved for
MMCONF_SUPPORT, even if MMCONF_SUPPORT_DEFAULT isn't selected.

Thanks,
Myles

Thanks,
Myles




More information about the coreboot mailing list