[coreboot] [PATCH] correct 'Fix for Erratum 343 for AMD Fam10h CPUs'

Scott Duplichan scott at notabs.org
Tue Sep 14 05:07:50 CEST 2010


This patch corrects a coding error in the original implementation
of 'Erratum 343 for AMD Fam10h CPUs' (rev 4345). The original code
sets msr c001_102a bit 3 when bit 35 was intended. 


Signed-off-by: Scott Duplichan <scott at notabs.org>

Index: src/cpu/amd/car/cache_as_ram.inc
===================================================================
--- src/cpu/amd/car/cache_as_ram.inc	(revision 5813)
+++ src/cpu/amd/car/cache_as_ram.inc	(working copy)
@@ -129,8 +129,8 @@
 	/* execute special read command for msr-register. Result is then in the EDX:EAX-registers (MSBs in EDX) */
 	rdmsr
 
-	/* Set bit 35 to 1 in EAX */
-	bts	$35, %eax
+	/* Set bit 35 to 1 in EDX:EAX */
+	bts	$35-32, %edx
 
 	/* write back the modified register EDX:EAX to the MSR specified in ECX */
 	wrmsr






More information about the coreboot mailing list