[coreboot] [patch] AMD Fam10 CPUID strings

Marc Jones marcj303 at gmail.com
Thu Sep 16 23:05:59 CEST 2010


On Wed, Sep 15, 2010 at 3:46 PM, Paul Menzel
<paulepanter at users.sourceforge.net> wrote:
> Dear Marc,
>
>
> Am Mittwoch, den 15.09.2010, 14:10 -0600 schrieb Marc Jones:
>> Add more Fam10 CPUID strings from the AMD revision guide. Includes
>> newer Phenom II.
>>
>> Signed-off-by: Marc Jones <marcj303 at gmail.com>
>
> I glanced over it and just found a missing space. I do not own the
> hardware. Is there another check I can do?
>
> If not and with the space fixed when committing this is
>
> Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>
>
>> Index: coreboot/src/cpu/amd/model_10xxx/processor_name.c
>> ===================================================================
>> --- coreboot.orig/src/cpu/amd/model_10xxx/processor_name.c      2010-09-15 13:38:47.000000000 -0600
>> +++ coreboot/src/cpu/amd/model_10xxx/processor_name.c   2010-09-15 13:56:53.000000000 -0600
>> @@ -3,6 +3,7 @@
>>   *
>>   * Copyright (C) 2007 Advanced Micro Devices, Inc.
>>   * Copyright (C) 2008 Peter Stuge
>> + * Copyright (C) 2010 Marc Jones <marcj303 at gmail.com>
>>   *
>>   * This program is free software; you can redistribute it and/or modify
>>   * it under the terms of the GNU General Public License as published by
>
> […]
>
>> @@ -93,28 +113,43 @@
>>         {0x00, 0x00, 0x07, "70"},
>>         {0x00, 0x00, 0x08, "80"},
>>         {0x00, 0x00, 0x09, "90"},
>> +       {0x00, 0x00, 0x09, " Processor"},
>> +       {0x00, 0x00, 0x09, "u Processor"},
>>         {0x00, 0x01, 0x00, "00 Dual-Core Processor"},
>>         {0x00, 0x01, 0x01, "00e Dual-Core Processor"},
>>         {0x00, 0x01, 0x02, "00B Dual-Core Processor"},
>>         {0x00, 0x01, 0x03, "50 Dual-Core Processor"},
>>         {0x00, 0x01, 0x04, "50e Dual-Core Processor"},
>>         {0x00, 0x01, 0x05, "50B Dual-Core Processor"},
>> +       {0x00, 0x01, 0x06, " Processor"},
>> +       {0x00, 0x01, 0x07, "e Processor"},
>> +       {0x00, 0x01, 0x09, "0 Processor"},
>> +       {0x00, 0x01, 0x0A,"0e Processor"},
>                            ^
>> +       {0x00, 0x01, 0x0B, "u Processor"},
>
> […]
>
>
> Thanks,
>
> Paul

Hi Paul,

Thanks for the review. I fixed the missing space.

r5815

Marc



-- 
http://se-eng.com




More information about the coreboot mailing list