[coreboot] [PATCH EHCI Debug Port setup for all AMD SB600/SB700 boards
stefan.reinauer at coresystems.de
Fri Sep 24 17:43:49 CEST 2010
On 9/23/10 11:39 PM, Peter Stuge wrote:
>> +#if CONFIG_USBDEBUG
>> +#include "southbridge/amd/sb700/sb700_enable_usbdebug.c"
>> +#include "pc80/usbdebug_serial.c"
> Can this go somewhere outside the mainboard directory?
> If anything does need to go in the mainboard dir now, then would it
> be enough to add pc80/usbdebug_serial.c, and without #if? The #if
> could easily be moved into that file to save repetitive lines. And
> I'm thinking that maybe sb700_enable_usbdebug.c could be pulled in
> when both SOUTHBRIDGE_AMD_SB700 and CONFIG_USBDEBUG are selected?
We could do a lot of such or similar improvements if we started not
including code but adding it to an object list.
Who's gonna do it?
More information about the coreboot