[coreboot] Fwd: [PATCH v3 1/1] libpayload: add support for finding and parsing Coreboot BIOS tables

Philip Prindeville philipp_subx at redfish-solutions.com
Tue Aug 23 07:45:14 CEST 2011

On 8/22/11 3:01 PM, Andrew Morton wrote:
> On Sun, 21 Aug 2011 17:01:28 -0700
> Philip Prindeville <philipp at redfish-solutions.com> wrote:
>> Attached.
> oookay.  I'll await a formal patch with all the cc's, etc.
> As for the "upstream" version: if/when this patch is merged, it *is*
> the upstream version.  The coreboot tree will need to drop the old
> version and migrate to the new.

So that we're on the same page, I took a different version of the code that is normally linked into standalone ELF images that run directly from the bootloader, much as (say) memtest86+ does.

I took that standalone library and ported it to run inside the linux kernel, adding printk()'s, phys_to_virt(), and ioremap() calls to make it work.

What I meant was I was hoping that some of the other changes made can be ported back into the arch/x86 version (like the using void * pointers instead of unsigned char * and then casting to struct pointers).

> Please be sure to carefully describe the background to the code within
> the final changelog.  Lots of people won't even know what coreboot
> *is*.  Spell this out completely and be sure to tell the kernel
> developers about the value of this patch to our users.

Good point.


More information about the coreboot mailing list