[coreboot] [PATCH] Add .text into romstage sections.

Marc Jones marcj303 at gmail.com
Tue Feb 22 22:25:02 CET 2011


On Tue, Feb 22, 2011 at 4:24 AM, Bao, Zheng <Zheng.Bao at amd.com> wrote:
> The text sections in *.romstage.o are called .text instead of .rom.text.
>
> The .text can be built in, but the _erom cannot be calculated correctly
>
> without this patch. Nobody uses _erom currently, so nobody seems cares it.
>
>
>
> Signed-off-by: Zheng Bao <zheng.bao at amd.com>
>
>
>
> Index: src/arch/x86/init/ldscript_fallback_cbfs.lb
>
> ===================================================================
>
> --- src/arch/x86/init/ldscript_fallback_cbfs.lb (revision 6374)
>
> +++ src/arch/x86/init/ldscript_fallback_cbfs.lb (working copy)
>
> @@ -35,6 +35,7 @@
>
>     .rom . : {
>
>           _rom = .;
>
>           *(.rom.text);
>
> +          *(.text);
>
>           *(.rom.data);
>
>           *(.rodata);
>
>           *(.rodata.*);

Zheng,

I think that .text should be like .data. and should only be in
ramstage. Is something being built into romstage that shouldn't be?

Marc



-- 
http://se-eng.com




More information about the coreboot mailing list